bdoyle0182 commented on code in PR #130:
URL:
https://github.com/apache/openwhisk-runtime-java/pull/130#discussion_r963961751
##########
core/java8/proxy/src/main/java/org/apache/openwhisk/runtime/java/action/Proxy.java:
##########
@@ -48,7 +51,20 @@ public Proxy(int port) throws IOException {
this.server.createContext("/init", new InitHandler());
this.server.createContext("/run", new RunHandler());
- this.server.setExecutor(null); // creates a default executor
+
+ if (Boolean.parseBoolean(System.getenv("__OW_ALLOW_CONCURRENT"))) {
+ ThreadPoolExecutor executor = new ThreadPoolExecutor(
+ 10, // Core size.
+ 25, // Max size.
Review Comment:
I'm not sure if we want to set the max pool size as this becomes a hard
bound on the language when the openwhisk setting per function is defined
elsewhere. So the user would have to know explicitly that for java they can't
increase their concurrency past 25 without getting performance degradation even
if they aren't cpu bounded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
