bdoyle0182 commented on code in PR #5375:
URL: https://github.com/apache/openwhisk/pull/5375#discussion_r1092753703
##########
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/Invoker.scala:
##########
@@ -91,7 +91,6 @@ object Invoker {
Map(servicePort -> 8080.toString) ++
ExecManifest.requiredProperties ++
kafkaHosts ++
- zookeeperHosts ++
Review Comment:
If you don't have it set but need it based on the arguments you passed to
the invoker, it will hit this same case where the invoker errors out and stops:
` // --uniqueName is defined with a valid value, id is empty, assign an
id via zookeeper
case CmdLineArgs(Some(unique), None, _, overwriteId) =>
if (config.zookeeperHosts.startsWith(":") ||
config.zookeeperHosts.endsWith(":")) {
abort(s"Must provide valid zookeeper host and port to use
dynamicId assignment (${config.zookeeperHosts})")
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
