style95 commented on PR #5391: URL: https://github.com/apache/openwhisk/pull/5391#issuecomment-1493497875
Once the queue manager receives a queue removed message, it will just remove the corresponding reference from queue pool and send an ack back to the sender. If there is any logic to re-add the reference to the queue pool then there might be a race condition, but it always removes the reference and no race condition happens. https://github.com/apache/openwhisk/blob/master/core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/QueueManager.scala#L204 One concern could be multiple acks sent from the queue manager, but it will also be handled by the wildcard case if there is no match for a certain state. https://github.com/apache/openwhisk/blob/master/core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/MemoryQueue.scala#L670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
