akrabat commented on code in PR #134: URL: https://github.com/apache/openwhisk-runtime-php/pull/134#discussion_r1268982460
########## README.md: ########## @@ -57,19 +67,21 @@ wsk action update myAction myAction.php --kind php:8.0 ### Local development ``` +./gradlew core:php8.2Action:distDocker ./gradlew core:php8.1Action:distDocker ./gradlew core:php8.0Action:distDocker ``` -This will produce the images `whisk/action-php-v8.1` and `whisk/action-php-v8.0` respectively. +This will produce the images `whisk/action-php-v8.1` and `whisk/action-php-v8.1`, `whisk/action-php-v8.0` respectively. Review Comment: Should be: > `whisk/action-php-v8.2`, `whisk/action-php-v8.1` and `whisk/action-php-v8.0` ########## core/php8.2Action/CHANGELOG.md: ########## @@ -0,0 +1,38 @@ +<!-- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +--> + +## Initial release + +- Added: PHP: 8.2.8 +- Added: PHP extensions in addition to the standard ones: + - bcmath + - curl + - gd + - intl + - mbstring + - mysqli + - pdo_mysql + - pdo_pgsql + - pdo_sqlite + - soap + - zip + - mongo +- Added: Composer packages: + - [guzzlehttp/guzzle](https://packagist.org/packages/guzzlehttp/guzzle): 7.4.5 Review Comment: We should ship Guzzle version 7.7.0. ########## core/php8.2Action/composer.json: ########## @@ -0,0 +1,11 @@ +{ + "config": { + "platform": { + "php": "8.2" + } + }, + "require": { + "guzzlehttp/guzzle": "7.4.5", Review Comment: Should update to `7.7.0` ########## core/php8.2Action/composer.json: ########## @@ -0,0 +1,11 @@ +{ + "config": { + "platform": { + "php": "8.2" + } + }, + "require": { + "guzzlehttp/guzzle": "7.4.5", + "ramsey/uuid": "4.4.0" Review Comment: Should update to `4.7.4` ########## core/php8.2Action/CHANGELOG.md: ########## @@ -0,0 +1,38 @@ +<!-- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +--> + +## Initial release + +- Added: PHP: 8.2.8 +- Added: PHP extensions in addition to the standard ones: + - bcmath + - curl + - gd + - intl + - mbstring + - mysqli + - pdo_mysql + - pdo_pgsql + - pdo_sqlite + - soap + - zip + - mongo +- Added: Composer packages: + - [guzzlehttp/guzzle](https://packagist.org/packages/guzzlehttp/guzzle): 7.4.5 + - [ramsey/uuid](https://packagist.org/packages/ramsey/uuid): 4.4.0 Review Comment: We should ship ramsey/uuid version 4.7.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
