cclauss commented on code in PR #5461:
URL: https://github.com/apache/openwhisk/pull/5461#discussion_r1477737517
##########
tests/src/test/scala/org/apache/openwhisk/core/containerpool/kubernetes/test/WhiskPodBuilderTests.scala:
##########
@@ -139,8 +139,8 @@ class WhiskPodBuilderTests extends FlatSpec with Matchers
with KubeClientSupport
val (pod, _) = builder.buildPodSpec(name, testImage, 2.MB, Map("foo" ->
"bar"), Map("fooL" -> "barV"), config)
withClue(Serialization.asYaml(pod)) {
val c = getActionContainer(pod)
-
c.getResources.getLimits.asScala.get("ephemeral-storage").map(_.getAmount)
shouldBe Some("1024Mi")
-
c.getResources.getRequests.asScala.get("ephemeral-storage").map(_.getAmount)
shouldBe Some("1024Mi")
+
c.getResources.getLimits.asScala.get("ephemeral-storage").map(_.getAmount)
shouldBe Some("1024")
Review Comment:
After #5459 is merged, this PR will merge cleanly into `master` without
these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
