gleono commented on PR #88: URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/88#issuecomment-2380658016
No worries, I understand. I was hesitant about the change too since I haven't seen the runtime identifier flag `-r` being used before. I found in the [Microsoft documentation](https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-publish) something that explains why it works, the `dotnet publish --self-contained` section mentions: > Publishes the .NET runtime with your application so the runtime doesn't need to be installed on the target machine. Default is true if a runtime identifier is specified and the project is an executable project (not a library project). The Minimal.csproj is indeed an executable, so the behavior was to bundle both the .Net runtime and the ASP.Net framework along the `/app`. Once the flag was removed the framework is now missing, resulting in the majority of the tests failing. I'm excited about having this built for both architectures, let me know if there is anything I can help with. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
