gleono commented on code in PR #92:
URL:
https://github.com/apache/openwhisk-runtime-dotnet/pull/92#discussion_r1796210133
##########
core/net6.0/proxy/Apache.OpenWhisk.Runtime.Common/Init.cs:
##########
@@ -21,31 +21,30 @@
using System.Reflection;
using System.Threading;
using System.Threading.Tasks;
-using System.Collections.Generic;
using Microsoft.AspNetCore.Http;
using Newtonsoft.Json.Linq;
namespace Apache.OpenWhisk.Runtime.Common
{
public class Init
{
- private readonly SemaphoreSlim _initSemaphoreSlim = new
SemaphoreSlim(1, 1);
+ private readonly SemaphoreSlim _initSemaphoreSlim = new(initialCount:
1, maxCount: 1);
+ private Type? _type;
+ private MethodInfo? _method;
+ private ConstructorInfo? _constructor;
+ private bool _awaitableMethod;
public bool Initialized { get; private set; }
- private Type Type { get; set; }
Review Comment:
private properties could very well be variables instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
