dorbae opened a new pull request, #5563:
URL: https://github.com/apache/openwhisk/pull/5563
<!--- Provide a concise summary of your changes in the Title -->
Refactor docker info formatter to use Go template syntax.
## Description
<!--- Provide a detailed description of your changes. -->
<!--- Include details of what problem you are solving and how your changes
are tested. -->
This change refactors the docker info command formatter argument in the
invoker deployment task to use the Go template format. The command will use
`docker info -f "{{json .}}"` instead of `docker info -f json`.
The latest Docker document illustrates [both 'json' and 'template'
options](https://docs.docker.com/reference/cli/docker/system/info/#options) for
the `-f` flag. However, the output was just `json` when I tested it on docker
client 18.x. ([Similar issue](https://github.com/moby/moby/issues/44469)) and
it has been fixed since [docker
23.0.5](https://github.com/docker/cli/pull/4230).
I suggest the usage of go template rather than json.
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Scheduler
- [x] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [x] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the
boxes that apply: -->
- [x] Bug fix (generally a non-breaking change which closes an issue).
- [ ] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing
behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered
all aspects of the change you're making. -->
- [x] I signed an [Apache
CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style
guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards)
and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
