adriancole commented on issue #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#issuecomment-307049718 > > + def getServiceName(): String = { > + component + "_" + action > > Here service name is name of logical unit within context of action > execution. Ex. invoker_activationinit or invoker_dockerpause etc. So > combination of two is span name here. > ok, then I'd probably not use the word serviceName here, as usually in zipkin serviceName is separate from spanName (especially in query). either that or make a code doc saying serviceName isn't zipkin's serviceName ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
