ddragosd commented on a change in pull request #2282: Distributed tracing
support #2192
URL:
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r121326154
##########
File path: common/scala/src/main/scala/whisk/core/connector/Message.scala
##########
@@ -53,7 +54,8 @@ case class ActivationMessage(
activationId: ActivationId,
activationNamespace: EntityPath,
content: Option[JsObject],
- cause: Option[ActivationId] = None)
+ cause: Option[ActivationId] = None,
+ traceMetadata: Option[SpanMetadata] = None)
Review comment:
@rabbah since the pluggability is another concern, do we want to mix these 2
concerns in a single PR ? Adding a pluggable solution now, would also mean to
update the existing implementation based on logging to disk, making the PR a
little too big IMHO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
