dubeejw commented on a change in pull request #2334: Added --last Activation
Flag
URL:
https://github.com/apache/incubator-openwhisk/pull/2334#discussion_r121468173
##########
File path: tools/cli/go-whisk-cli/commands/activation.go
##########
@@ -254,12 +255,17 @@ func lastFlag(args []string) ([]string, error) {
}
if len(activations) == 0 {
- whiskErr := whisk.MakeWskError(errors.New("No activations found"),
whisk.EXITCODE_ERR_GENERAL, whisk.DISPLAY_MSG, whisk.DISPLAY_USAGE)
+ errStr := fmt.Sprintf("%s%s %s %s",
"clinet.Activation.",funcName,"error:", "No activations found")
Review comment:
The user should not be informed of the function name directly through an
error message. Such information should be displayed in debug messages. Also,
the error message is not very clear to someone that doesn't know the internal
workings of the CLI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
