csantanapr commented on a change in pull request #2112: Allow docker actions with zip files. URL: https://github.com/apache/incubator-openwhisk/pull/2112#discussion_r122345876
########## File path: docs/actions.md ########## @@ -827,12 +827,19 @@ For the instructions that follow, assume that the Docker user ID is `janesmith` ``` - wsk action create --docker example janesmith/blackboxdemo + wsk action create example --docker janesmith/blackboxdemo Review comment: It's a braking CLI change only is user was using `create --docker action_name janesmith/blackboxdemo` but if user was using `create action_name --docker janesmith/blackboxdemo` this continues to work I think is low risk, to make the change, and try to explain the benefits of having the new syntax, is more consistent with the other actions kinds ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
