csantanapr commented on a change in pull request #2120: Add Swift 3.1.1 as a
kind
URL:
https://github.com/apache/incubator-openwhisk/pull/2120#discussion_r122579334
##########
File path: tests/src/test/scala/system/basic/WskBasicSwift3Tests.scala
##########
@@ -33,19 +33,20 @@ import common.TestUtils.RunResult
import spray.json.JsObject
@RunWith(classOf[JUnitRunner])
-class WskBasicSwiftTests
+class WskBasicSwift3Tests
extends TestHelpers
with WskTestHelpers
with JsHelpers {
implicit val wskprops = WskProps()
val wsk = new Wsk
val defaultAction = Some(TestUtils.getTestActionFilename("hello.swift"))
- val currentSwiftDefaultKind = "swift:3"
+ lazy val currentSwiftDefaultKind = "swift:3"
behavior of "Swift runtime"
- it should "Map a kind of swift:default to the current default swift
runtime" in withAssetCleaner(wskprops) {
+ // ignore this while deprecated swift:3 is still default
+ ignore "Map a kind of swift:default to the current default swift runtime"
in withAssetCleaner(wskprops) {
Review comment:
@paulcastro @rabbah
Do not ignore, don't assume a default values, now it's driven thru manifest
configuration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
