mdeuser commented on a change in pull request #2366: Add Test to Ensure
Preservation of Annotations for Action Web Flag
URL:
https://github.com/apache/incubator-openwhisk/pull/2366#discussion_r122786793
##########
File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala
##########
@@ -630,6 +630,39 @@ class WskBasicUsageTests
}
}
+ it should "ensure --web flag does not remove existing annotations" in
withAssetCleaner(wskprops) {
+ (wp, assetHelper) =>
+ val name = "webaction"
+ val file = Some(TestUtils.getTestActionFilename("echo.js"))
+ val annots = Map("someKey" -> JsString("someValue"))
+
+ assetHelper.withCleaner(wsk.action, name) {
+ (action, _) => action.create(name, file, annotations = annots)
+
Review comment:
nit. blank line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services