style95 commented on issue #1790: Add documentation for docker for mac
URL: 
https://github.com/apache/incubator-openwhisk/pull/1790#issuecomment-309686270
 
 
   @rabbah @markusthoemmes @csantanapr 
   Please review this.
   
   To recall, let me recap the changes.
   
   1. Socat container.
   This is to enable docker remote api.
   
   2. Docker-machine and Mac environment in ansible.
   With this pr, there will be one more environment, `docker-machine`.
   This environment is kept for those who use OW with docker-machine.
   In the future, this environment will be deprecated.
   
   So, `mac` environment means Docker for mac environment.
   
   
   3. Convert `AkkaHttpUtils` to `Play-ws client`
   Since `AkkaHttpUtils` does not support proxy configuration, http client is 
changed to `play-ws`.
   There is no change in logic.
   
   4. Squid proxy container
   This is only to run unit tests with Docker for mac.
   It will forward all the request to a given target container.
   
   Since there was no retry delay on connection error in upstream squid proxy, 
following tests failed.
   
   ```
   actionContainers.DockerExampleContainerTests > bad containers should timeout 
bad proxy with exception FAILED
   ```
   
   So I added retry delay and manually compiled it and built docker container.
   Now it works as expected.
   
   
   One remaining task is update 
[this](https://github.com/apache/incubator-openwhisk/pull/1790/files#diff-5a5d069dcad99a9f8109ac77d1b9860cR60)
 to my manually built squid container.
   
   I think it would be the best to publish that squid container to [openwhisk 
namespace](https://hub.docker.com/u/openwhisk/) in docker hub.
   But if it`s not possible, I will publish it in my namesapce.(ex: 
`style95/squid:3.5`)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to