mrutkows commented on a change in pull request #278: Fixing JAR failure
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/278#discussion_r123338370
##########
File path: parsers/manifest_parser.go
##########
@@ -274,6 +274,9 @@ func (dm *YAMLParser) ComposeActions(mani *ManifestYAML,
manipath string) (ar []
wskaction.Exec.Kind = action.Runtime
}
+ // we can specify the name of the action entry point using main
+ wskaction.Exec.Main = action.Main
Review comment:
@lzbj @pritidesai we should test that we can support Lambda "handlers", that
is reassigning "main":
> exports.main = ?myAWSLambdaHandler?
which is allowed... but, if you are asking should we test to make sure there
is a "main" function before executing then YES, we SHOULD test and error out
with a nice error message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
