rabbah commented on issue #2383: docker pull invoker images runtimes from 
manifest
URL: 
https://github.com/apache/incubator-openwhisk/pull/2383#issuecomment-310376307
 
 
   look in exec helpers
   
    ``` protected def js(code: String, main: Option[String] = None): Exec = {
           CodeExecAsString(RuntimeManifest(NODEJS, imagename(NODEJS), 
deprecated = Some(true)), trim(code), main.map(_.trim))
       }
   
       protected def js6(code: String, main: Option[String] = None): Exec = {
           CodeExecAsString(RuntimeManifest(NODEJS6, imagename(NODEJS6), 
default = Some(true)), trim(code), main.map(_.trim))
       }
   
       protected def jsDefault(code: String, main: Option[String] = None) = {
           js6(code, main)
       }
   ```
   
   the value of deprecated in the test is None, not Some(false) which it needs 
to be for the equality to hold; that's my quick guess based on the log.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to