clebertsuconic commented on a change in pull request #2414: SPI approach for
pluggable implementations
URL:
https://github.com/apache/incubator-openwhisk/pull/2414#discussion_r123616523
##########
File path:
common/scala/src/main/scala/whisk/connector/kafka/KafkaMessagingProvider.scala
##########
@@ -0,0 +1,37 @@
+package whisk.connector.kafka
+
+import akka.actor.ActorSystem
+import scaldi.Injector
+import whisk.common.Logging
+import whisk.core.WhiskConfig
+import whisk.core.connector.MessageConsumer
+import whisk.core.connector.MessageProducer
+import whisk.core.connector.MessagingProvider
+import whisk.spi.SpiFactoryModule
+/**
+ * Created by tnorris on 6/20/17.
+ */
+class KafkaMessagingProvider(actorSystem:ActorSystem,
config:WhiskConfig)(implicit logging:Logging) extends MessagingProvider {
Review comment:
What I still don't get on OpenWhisk.. is why not call this
MessagingPRovider, and Kafka being the implementation?
If you want to make it pluggable, make it pluggable...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
