dubeejw commented on a change in pull request #2326: (Review) Alphabetize
URL:
https://github.com/apache/incubator-openwhisk/pull/2326#discussion_r124101073
##########
File path: tools/cli/go-whisk/whisk/package.go
##########
@@ -83,6 +85,39 @@ type PackageListOptions struct {
Docs bool `url:"docs,omitempty"`
}
+/*
+ * Compare(s) compares Package p to Sortable s for the purpose of sorting.
+ * params: Sortable type s that is also of type Package (REQUIRED)
+ * ***Method of type Sortable***
+ * ***By default, sorts Alphabetically***
+ */
+func(xPackage Package) Compare(sortable Sortable) bool{
+ // convert s back to proper type
Review comment:
`s` doc here and above wasn't updated with variable name change. Looks like
the same issue throughout each file this function is in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
