rabbah commented on a change in pull request #2230: Improve
ExecutableWhiskAction coverage and general typesafety
URL:
https://github.com/apache/incubator-openwhisk/pull/2230#discussion_r115755955
##########
File path:
core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala
##########
@@ -105,7 +104,7 @@ protected[actions] trait PrimitiveActions {
val startActivation = transid.started(this, if (blocking)
LoggingMarkers.CONTROLLER_ACTIVATION_BLOCKING else
LoggingMarkers.CONTROLLER_ACTIVATION)
val startLoadbalancer = transid.started(this,
LoggingMarkers.CONTROLLER_LOADBALANCER, s"[POST] action activation id:
${message.activationId}")
- val postedFuture = loadBalancer.publish(action, message,
activeAckTimeout)
+ val postedFuture = loadBalancer.publish(action.toWhiskAction, message,
activeAckTimeout)
Review comment:
why need to go back to the general type?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
