rabbah commented on a change in pull request #2421: Fix order of messages being
sent by the ContainerPool.
URL:
https://github.com/apache/incubator-openwhisk/pull/2421#discussion_r124598605
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
##########
@@ -120,11 +120,7 @@ class ContainerPool(
// Container got removed
case ContainerRemoved =>
freePool.remove(sender())
- busyPool.remove(sender())
-
- // Activation completed
- case ActivationCompleted =>
- feed ! ContainerReleased
+ busyPool.remove(sender()).foreach(_ => feed ! ContainerReleased)
Review comment:
so where previously the slow was released on completion, and a new request
may be received when a container isn't available, instead, indicate capacity
availability when the container pool can actually readily allocate a new slot -
is that correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
