mdeuser commented on a change in pull request #2435: Ensure Action Update
Creates a Web Action
URL:
https://github.com/apache/incubator-openwhisk/pull/2435#discussion_r124618277
##########
File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala
##########
@@ -652,14 +655,43 @@ class WskBasicUsageTests
"key" -> JsString("web-export"),
"value" -> JsBoolean(true)),
JsObject(
+ "key" -> JsString(origKey),
+ "value" -> origValue),
+ JsObject(
"key" -> JsString("raw-http"),
"value" -> JsBoolean(false)),
JsObject(
"key" -> JsString("final"),
"value" -> JsBoolean(true)),
JsObject(
- "key" -> JsString(key),
- "value" -> value),
+ "key" -> JsString(updatedKey),
+ "value" -> updatedValue),
+ JsObject(
+ "key" -> JsString("exec"),
+ "value" -> JsString("nodejs:6")))
+ }
+
+ it should "ensure action update creates an action with --web flag" in
withAssetCleaner(wskprops) {
+ (wp, assetHelper) =>
+ val name = "webaction"
+ val file = Some(TestUtils.getTestActionFilename("echo.js"))
+
+ assetHelper.withCleaner(wsk.action, name) {
+ (action, _) => action.create(name, file, web = Some("true"),
update = true)
Review comment:
To validate handling of existing action annotations, should the action be
created first and then updated?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
