rabbah commented on a change in pull request #2326: (Review) Alphabetize
URL:
https://github.com/apache/incubator-openwhisk/pull/2326#discussion_r124671632
##########
File path: tests/src/test/scala/system/basic/WskBasicTests.scala
##########
@@ -814,6 +877,37 @@ class WskBasicTests
stderr should include regex (s"""Unable to get rule '$name': The
requested resource does not exist. \\(code \\d+\\)""")
}
+ it should "return a list of alphabetized rules" in
withAssetCleaner(wskprops) {
Review comment:
you can get fancier and reduce the tests for rules, actions, triggers, and
packages into one canonical set.
you'd have to pass in the "type" as in `wsk.trigger` as part of a
`Seq(wsk.trigger, wsk.action, ...)` and wrap the test with a foreach on the
sequence. I suggest you try that as a later improvement (separate pr) to reduce
clone-and-own code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
