mrutkows commented on a change in pull request #149: Updating all Python files
to have ASF licenses and pass PEP8 tests
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/149#discussion_r124844451
##########
File path: provider/consumer.py
##########
@@ -65,20 +72,25 @@ def start(self):
# should only be called by the Doctor thread
def restart(self):
if self.thread.desiredState() is Consumer.State.Dead:
- logging.info('[{}] Request to restart a consumer that is already
slated for deletion.'.format(self.trigger))
+ logging.info("[{}] Request to restart a consumer "
+ "that is already slated for "
+ "deletion.".format(self.trigger))
return
with self.__lock:
self.__restartCount += 1
- logging.info('[{}] Quietly shutting down consumer for
restart'.format(self.trigger))
+ logging.info("[{}] Quietly shutting down consumer for "
+ "restart".format(self.trigger))
self.thread.setDesiredState(Consumer.State.Restart)
self.thread.join()
- logging.info('Consumer has shut down')
+ logging.info("Consumer has shut down")
Review comment:
@bjustin-ibm Single quotes for symbolic strings, double quotes for
(potentially) interpolated (or language translatable) strings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
