markusthoemmes commented on a change in pull request #2452: Nuke Consul.
URL:
https://github.com/apache/incubator-openwhisk/pull/2452#discussion_r125179098
##########
File path:
core/invoker/src/main/scala/whisk/core/container/ContainerUtils.scala
##########
@@ -92,14 +92,13 @@ trait ContainerUtils {
val cpuArg = Array("-c", cpuShare.toString)
val memoryArg = Array("-m", s"${limits.memory.megabytes}m",
"--memory-swap", s"${limits.memory.megabytes}m")
val capabilityArg = Array("--cap-drop", "NET_RAW", "--cap-drop",
"NET_ADMIN")
- val consulServiceIgnore = Array("-e", "SERVICE_IGNORE=true")
Review comment:
Needs to be changed in the new pool as well, see `DockerContainer.scala`
line 75 (you probably didn't get it as a match in your directory-wide "consul"
search? ? )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services