rabbah commented on a change in pull request #2454: Deal with jvm process leak
in TestUtils
URL:
https://github.com/apache/incubator-openwhisk/pull/2454#discussion_r125685361
##########
File path: tests/src/test/scala/common/TestUtils.java
##########
@@ -327,6 +327,7 @@ public String call() throws IOException {
logger.info("RunResult: " + rr);
}
rr.validateExitCode(expectedExitCode);
+ executor.shutdown();
Review comment:
I'm tempted to suggested making the executor a static instance. What do you
think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
