mdeuser commented on a change in pull request #2461: Get Action URL from CLI
(Review)
URL:
https://github.com/apache/incubator-openwhisk/pull/2461#discussion_r126003817
##########
File path: tools/cli/go-whisk-cli/commands/action.go
##########
@@ -918,6 +926,7 @@ func init() {
actionInvokeCmd.Flags().BoolVarP(&flags.action.result, "result", "r",
false, wski18n.T("blocking invoke; show only activation result (unless there is
a failure)"))
actionGetCmd.Flags().BoolVarP(&flags.common.summary, "summary", "s",
false, wski18n.T("summarize action details"))
+ actionGetCmd.Flags().BoolVarP(&flags.action.url, "url", "r", false,
wski18n.T("get action url"))
Review comment:
How does the CLI do when both the `--url` flag and `--summary` flag are
specified. Is one ignored (if so, how does user know in doc and in the
results)? Both honored?
And if both `--url` and the `[FIELD_FILTER]` are specified together?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
