mdeuser commented on a change in pull request #2424: (Review) Leading Slash
(CLI issue #2328)
URL:
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r126024489
##########
File path: tools/cli/go-whisk-cli/commands/util.go
##########
@@ -77,10 +88,13 @@ Examples:
func parseQualifiedName(name string) (QualifiedName, error) {
var qualifiedName QualifiedName
- // If name has a preceding delimiter (/), it contains a namespace.
Otherwise the name does not specify a namespace,
- // so default the namespace to the namespace value set in the properties
file; if that is not set, use "_"
+ // If name has a preceding delimiter (/), or if it has two delimiters with
a leading non-empty string, then
+ // it contains a namespace. Otherwise the name does not specify a
namespace, so default the namespace to the
+ // namespace value set in the properties file; if that is not set, use "_"
+ name = replaceMissingLeadSlash(name)
+ parts := strings.Split(name, "/")
if strings.HasPrefix(name, "/") {
- parts := strings.Split(name, "/")
+ //parts = strings.Split(name, "/")
Review comment:
Remove commented out code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
