mrutkows commented on a change in pull request #41: WIP: Add support for 
scancode in Travis; update README with license & build badges
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/41#discussion_r126065951
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -10,7 +10,9 @@ services:
   - docker
 
 before_install:
+  - ./tools/travis/setupscan.sh
 
 Review comment:
   
   
   All the other repos use the ./tools/travis conventions. I called Daniel 
Lavine and asked him if there was some reason to use ./.travis, but he could 
not think of any and my searches did not yield anything meaningful (although I 
did see a few repos/projects used this as the location). Please let me know if 
there is special meaning to using ./.travis as if there is a compelling reason, 
we may want to change all the other repos. as well. In any event, it would be 
desirable to have all repos. use the same directory conventions where possible 
IMO; it also helps with setting up "path exclusions" for uniform code scanning 
as well.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to