dubeejw commented on a change in pull request #2458: wsk CLI should tolerate
APIs that do not yet have a mapped action
URL:
https://github.com/apache/incubator-openwhisk/pull/2458#discussion_r126180202
##########
File path: tools/cli/go-whisk-cli/commands/api.go
##########
@@ -864,21 +864,34 @@ var apiCreateCmdV2 = &cobra.Command{
for op, opv := range retApi.Swagger.Paths[path] {
whisk.Debug(whisk.DbgInfo, "Path operation: %s\n", op)
var fqActionName string
- if (len(opv.XOpenWhisk.Package) > 0) {
+ if (opv.XOpenWhisk == nil) {
+ fqActionName = ""
+ } else if (len(opv.XOpenWhisk.Package) > 0) {
fqActionName =
"/"+opv.XOpenWhisk.Namespace+"/"+opv.XOpenWhisk.Package+"/"+opv.XOpenWhisk.ActionName
} else {
fqActionName =
"/"+opv.XOpenWhisk.Namespace+"/"+opv.XOpenWhisk.ActionName
}
whisk.Debug(whisk.DbgInfo, "baseUrl %s Path %s Path obj
%+v\n", baseUrl, path, opv)
- fmt.Fprintf(color.Output,
- wski18n.T("{{.ok}} created API {{.path}} {{.verb}} for
action {{.name}}\n{{.fullpath}}\n",
- map[string]interface{}{
- "ok": color.GreenString("ok:"),
- "path":
strings.TrimSuffix(retApi.Swagger.BasePath, "/") + path,
- "verb": op,
- "name": boldString(fqActionName),
- "fullpath": managedUrl,
- }))
+ if len(fqActionName) > 0 {
Review comment:
@mdeuser, looks like those tests in ApiGwRoutemgmtActionTests are for the
backend service. I mean tests to ensure the functionality added to the CLI
works as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
