dubeejw commented on a change in pull request #197: Use one canary document per
provider instance
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/197#discussion_r126508692
##########
File path: provider/database.py
##########
@@ -83,33 +83,37 @@ def createCanary(self):
maxRetries = 3
retryCount = 0
+ instance = os.getenv('INSTANCE', 'messageHubTrigger-0')
Review comment:
Feels like the assignments to `instance` and `canaryId` should occur outside
of this function. Otherwise, you are unnecessarily redefining them every time
`createCanary()` is invoked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
