markusthoemmes commented on a change in pull request #2427: Support client
certificate on cli and nginx
URL:
https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r126665162
##########
File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala
##########
@@ -108,6 +108,36 @@ class WskBasicUsageTests
}
}
+ it should "set valid cert key to get expected success result for client
certificate verification" in {
+ val tmpwskprops = File.createTempFile("wskprops", ".tmp")
+ try {
+ val namespace = wsk.namespace.list().stdout.trim.split("\n").last
+ val env = Map("WSK_CONFIG_FILE" -> tmpwskprops.getAbsolutePath())
+ val stdout = wsk.cli(Seq("property", "set", "-i", "--apihost",
wskprops.apihost, "--auth", wskprops.authKey,
+ "--cert", wskprops.cert, "--key", wskprops.key, "--namespace",
namespace), env = env).stdout
Review comment:
Adding a comment on how `--namespace` forces an API request and thereby a
cert. validation would be helpful to understand the testcase later on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
