rabbah commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README. URL: https://github.com/apache/incubator-openwhisk-sample-matos/pull/1#issuecomment-314786015 FWIW I run scan code as a precommit hook. So it will fail locally before I can push any changes. This is in my opinion the way we should be using it (Travis being the safety valve for non conformance). I think it checks for tabs instead of spaces, end of line whitespace, missing newline at eof, and confirming/missing license header. I think Matt generalized the license header checks but the core checks are the same. In the future... it would be nice if it also applied code formatting checks and other linters but this is not in scope today. I think our readme has a mention of the hook but maybe not all these points. It might be worth adding then. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
