markusthoemmes commented on a change in pull request #2218: Port Controller 
from Spray to Akka
URL: 
https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127051652
 
 

 ##########
 File path: 
core/controller/src/main/scala/whisk/core/controller/Activations.scala
 ##########
 @@ -205,12 +206,37 @@ trait WhiskActivationsApi
     }
 
     /** Custom deserializer for query parameters "since" and "upto" into a 
valid Instant. */
-    private implicit val stringToInstantDeserializer = new 
FromStringDeserializer[Instant] {
+    private implicit val stringToInstantDeserializer = new 
FromStringUnmarshaller[Instant] {
 
 Review comment:
   Are these needed anymore? In general: Try to scrub all the spray 
dependencies and then remove everything that's related to that.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to