glikson commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README. URL: https://github.com/apache/incubator-openwhisk-sample-matos/pull/1#issuecomment-314906144 I am fine with either option On Jul 12, 2017 12:24 PM, "Matt Rutkowski" <[email protected]> wrote: > @bjustin-ibm <https://github.com/bjustin-ibm> I am willing abd have > customized the tool to allow leading indents for GoLang; however, in many > of these repos. there is not uniformity from file to file (of the same > runtime language type). Even within the same file some lines use tab > indents or not; I am for uniformity as different devs. use different > editors which treat tab char (replacement) differently and when opening a > file should not have to (especially within the same file) see some lines > indented differently; this speaks to code readability. At min. there should > be uniformity in use of tabs in the same file; in the same project it would > be much saner to have some standard as one file has it (tabs) and another > in the same path does not (same language). For some languages Tabs are a > critical feature (e.g., Go where leading indents are the accepted norm for > the community, and in Python tabs are a death sentence as there are > stricter implications for line continuation and computational evaluation). > The first 5 repos. that had scancode enabled when I started this "journey" > (not by choice) all happily applied the same rules and everyone seemed fine > with having these rules imposed as part of the build process. Personally, I > just want to make sure that each repo. has its rules down for uniformity > (even better if they follow what has been established by main > openwhisk/catalog, etc.) and can even supply their own .cfg file that > reflects it, but we do not even have uniformity within the same path or > within even the same file today. > > ? > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-openwhisk-sample-matos/pull/1#issuecomment-314821934>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABiItTqWE7WNYnWnIJUIXoGEIiyXNwTJks5sNPLGgaJpZM4OTlNE> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
