rabbah commented on issue #2482: Add container pool health status in invoker
URL: 
https://github.com/apache/incubator-openwhisk/pull/2482#issuecomment-315290700
 
 
   Look in InvokerSupervision. It actually tried to invoke an action. If that 
fails it will make the invoker unhealthy. Yes some requests might get queued on 
that invoker while the health protocol completes but eventually it should 
detect a failing invoker. 
   
       /** Scheduler to send test activations when the invoker is unhealthy. */
       onTransition {
           case _ -> UnHealthy => {
               invokeTestAction()
               setTimer(InvokerActor.timerName, Tick, 1.minute, true)
           }
           case UnHealthy -> _ => cancelTimer(InvokerActor.timerName)
       }
   
   But I now suspect there's a bug in the protocol in the case of a missing 
active ack. I have to check again in the morning and confirm if a test exists 
in that case. 
   
   I think your change is actually undesirable. In that the invoker pool can be 
full because of load - that should not mark the invoker unavailable. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to