rabbah commented on a change in pull request #2475: Fix error string replicate
issue.
URL:
https://github.com/apache/incubator-openwhisk/pull/2475#discussion_r127453443
##########
File path: tools/cli/go-whisk/whisk/wskerror.go
##########
@@ -34,6 +34,7 @@ const NO_DISPLAY_PREFIX bool = false
const APPLICATION_ERR bool = true
const NO_APPLICATION_ERR bool = false
const TIMED_OUT bool = true
+const UNABLE_CREATE_ACTION_ERR string = "Unable to create action '{{.name}}':
{{.err}}"
Review comment:
@mdeuser this was the spirit of the intended change/this pr. I think @lzbj
initially interpreted the issue differently. So we should decide: is it worth
making the change of passing the string around by pointer? If so, then yes
decouple the prs. If not, drop that commit and making the intended change for
reducing the number of times an error message is used. For the latter, I defer
to you and @dubeejw and @lzbj for the best way to do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
