jessealva commented on a change in pull request #2462: Updating the way we
print names in the Cli Fixes #1155
URL:
https://github.com/apache/incubator-openwhisk/pull/2462#discussion_r127483553
##########
File path: tools/cli/go-whisk-cli/wski18n/resources/en_US.all.json
##########
@@ -829,7 +829,7 @@
},
{
"id": "{{.ok}} deleted action {{.name}}\n",
- "translation": "{{.ok}} deleted action {{.name}}\n"
+ "translation": "{{.ok}} deleted action '{{.name}}'\n"
Review comment:
So I agree that the keys will be out of sync, but I think its weird and
wrong they have the translation string as the key to begin with. Thats
unnecessary and confusing in my opinion, just didnt want to go up and change
them all to some other string which is more easily searchable.
At the same time, boldness does not show on tools like Jenkins, travis, etc.
Only on the CLI, so there could still be a reason to quote them @mdeuser
@dubeejw
Although if you guys still think no, i can remove the quoting from the
bolded strings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
