rabbah commented on a change in pull request #2138: i957 adding fields to
activation list
URL:
https://github.com/apache/incubator-openwhisk/pull/2138#discussion_r111406626
##########
File path: ansible/files/whisks_design_document_for_activations_db.json
##########
@@ -5,7 +5,7 @@
"map": "function (doc) {\n var PATHSEP = \"/\";\n var isActivation =
function (doc) { return (doc.activationId !== undefined) };\n var collection =
function (doc) {\n if (isActivation(doc)) return \"activations\";\n
return \"??\";\n };\n\n try {\n var ns = doc.namespace.split(PATHSEP);\n
var root = ns[0]; ns.shift();\n var type = collection(doc);\n var date =
new Date(doc.start || doc.updated);\n var value = {collection: type,
namespace: doc.namespace, name: doc.name, version: doc.version, publish:
doc.publish, annotations: doc.annotations};\n value.activationId =
doc.activationId;\n emit([root, date], value);\n } catch (e) {}\n}\n"
},
"activations": {
- "map": "function (doc) {\n var PATHSEP = \"/\";\n\n try {\n var
date = new Date(doc.start || doc.updated);\n emit([doc.namespace,
date.getTime(), doc.name], {namespace: doc.namespace, name: doc.name, version:
doc.version, publish: doc.publish, annotations: doc.annotations, activationId:
doc.activationId});\n emit([doc.namespace+PATHSEP+doc.name, date.getTime()],
{namespace: doc.namespace, name: doc.name, version: doc.version, publish:
doc.publish, annotations: doc.annotations, activationId: doc.activationId});\n
} catch (e) {}\n}\n"
+ "map": "function (doc) {\n var PATHSEP = \"/\";\n\n try {\n var
date = new Date(doc.start || doc.updated);\n emit([doc.namespace,
date.getTime(), doc.name], {namespace: doc.namespace, name: doc.name, version:
doc.version, publish: doc.publish, annotations: doc.annotations, activationId:
doc.activationId, start: doc.start, duration: doc.duration, response:
{statusCode: doc.response.statusCode}});\n
emit([doc.namespace+PATHSEP+doc.name, date.getTime()], {namespace:
doc.namespace, name: doc.name, version: doc.version, publish: doc.publish,
annotations: doc.annotations, activationId: doc.activationId, start: doc.start,
duration: doc.duration, response: {statusCode: doc.response.statusCode}});\n }
catch (e) {}\n}\n"
Review comment:
you should not use `getTime` here - this will be non-deterministic and
affect the results of the view is what will appear to be surprising ways.
What is the goal? Isn't start time already in the record?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
