rabbah commented on a change in pull request #2414: SPI approach for pluggable implementations URL: https://github.com/apache/incubator-openwhisk/pull/2414#discussion_r128921333
########## File path: common/scala/src/main/scala/whisk/core/database/ArtifactStoreProvider.scala ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package whisk.core.database + +import akka.actor.ActorSystem +import spray.json.RootJsonFormat +import whisk.common.Logging +import whisk.core.WhiskConfig +import whisk.spi.Spi +import whisk.spi.SpiProvider + +/** + * An Spi for providing ArtifactStore implementations + */ + +trait ArtifactStoreProvider extends Spi { + def makeStore[D <: DocumentSerializer](config: WhiskConfig, name: WhiskConfig => String)( + implicit jsonFormat: RootJsonFormat[D], + actorSystem: ActorSystem, + logging: Logging): ArtifactStore[D] Review comment: @tysonnorris what do you think about the suggestion above? I think this is likely to evolve further but we can at least start to experiment with the plugins. It may be worth though consolidating those dependencies for now since it will avoid having to change dependent adaptors. I can run a jenkins job to execute the full test suite in the meantime to make sure nothing broke. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
