rabbah commented on a change in pull request #2533: Add the ability to define
user-specific throttles.
URL:
https://github.com/apache/incubator-openwhisk/pull/2533#discussion_r129855480
##########
File path:
core/controller/src/main/scala/whisk/core/entitlement/RateThrottler.scala
##########
@@ -67,7 +68,7 @@ private class RateInfo(maxPerMinute: Int) {
* Increments operation count in the current time window by
* one and checks if still below allowed max rate.
*/
- def check(): Boolean = {
+ def check(maxPerMinute: Int): Boolean = {
Review comment:
perhaps a comment here that the check always accepts the max allowed per
minute since throttles may change dynamically. (maybe here or in the caller
above.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
