markusthoemmes commented on a change in pull request #2533: Add the ability to
define user-specific throttles.
URL:
https://github.com/apache/incubator-openwhisk/pull/2533#discussion_r129859766
##########
File path: common/scala/src/main/scala/whisk/core/entity/Identity.scala
##########
@@ -27,8 +27,15 @@ import whisk.core.database.MultipleReadersSingleWriterCache
import whisk.core.database.NoDocumentException
import whisk.core.entitlement.Privilege
import whisk.core.entitlement.Privilege.Privilege
+import scala.util.Try
-protected[core] case class Identity(subject: Subject, namespace: EntityName,
authkey: AuthKey, rights: Set[Privilege]) {
+case class UserLimits(invocationsPerMinute: Option[Int] = None,
concurrentInvocations: Option[Int] = None, firesPerMinute: Option[Int] = None)
Review comment:
I thought about this as well, but I figured this is more dynamic as in: If
we add more namespace-definable limits in the future (and i expect us to) the
schema is easily adapted to that vs. making the whole class `Option`al.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
