rabbah commented on issue #2532: Update wsk test fwk to allow tests to obfuscate sensitive output URL: https://github.com/apache/incubator-openwhisk/pull/2532#issuecomment-318387380 ok then i'm confused - if we agree (and i thought we did) that show cmd is useful for debugging then we should not hide strings in those commands (instead hide the strings in the with clue error message only). so i suggest backing out the change for the `if (showCmd) ...` bit. if then there's a concern that there are tests which show the cmd and hence printing sensitive info, all of those instances should be turned to off. if you want a second pr to turn off all instances of show cmd, fine. but i would still remove the change for showCmd. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
