rabbah commented on a change in pull request #2541: Clean Up CLI Tests (Review)
URL:
https://github.com/apache/incubator-openwhisk/pull/2541#discussion_r130034196
##########
File path: tests/src/test/scala/common/Wsk.scala
##########
@@ -1007,19 +1006,24 @@ trait WaitFor {
object Wsk {
private val binaryName = "wsk"
+ private val cliPath = getCLIPath
+
+ exists
/** What is the path to a downloaded CLI? **/
private def getDownloadedGoCLIPath = {
s"${System.getProperty("user.home")}${File.separator}.local${File.separator}bin${File.separator}${binaryName}"
}
- def exists() = {
- val cliPath = if (WhiskProperties.useCLIDownload)
getDownloadedGoCLIPath else WhiskProperties.getCLIPath
+ private def getCLIPath = {
+ if (WhiskProperties.useCLIDownload) getDownloadedGoCLIPath else
WhiskProperties.getCLIPath
+ }
+
+ private def exists = {
Review comment:
Seems this doesn't need to be a method then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
