markusthoemmes commented on a change in pull request #2218: Port Controller
from Spray to Akka
URL:
https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130340078
##########
File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala
##########
@@ -321,7 +326,21 @@ trait WhiskTriggersApi extends WhiskCollectionAPI {
* @param rule the rule to send
* @param status the status to include in the response
*/
- private def completeAsTriggerResponse(trigger: WhiskTrigger):
RequestContext => Unit = {
+ private def completeAsTriggerResponse(trigger: WhiskTrigger):
RequestContext => Future[RouteResult] = {
complete(OK, trigger.withoutRules)
}
+
+ implicit val entityToJsObject: Unmarshaller[HttpEntity, JsObject] = {
Review comment:
Same as above on standard unmarshallers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
