rabbah commented on a change in pull request #2524: Docker for mac support
URL:
https://github.com/apache/incubator-openwhisk/pull/2524#discussion_r131037965
##########
File path: ansible/roles/invoker/tasks/deploy.yml
##########
@@ -26,9 +26,25 @@
retries: "{{ docker.pull.retries }}"
delay: "{{ docker.pull.delay }}"
-- name: determine docker root dir
+- name: "determine docker root dir on docker-machine"
uri: url="http://{{ inventory_hostname }}:{{ docker.port }}/info"
return_content=yes
- register: dockerInfo
+ register: dockerInfo_output
+ when: whisk_version_name == "mac"
+
+- set_fact:
+ dockerInfo: "{{ dockerInfo_output['json'] }}"
+ when: whisk_version_name == "mac"
+
+- name: "determine docker root dir"
+ shell: echo -e "GET http:/v1.24/info HTTP/1.0\r\n" | nc -U
/var/run/docker.sock | grep "{"
+ args:
+ executable: /bin/bash
+ register: dockerInfo_output
+ when: whisk_version_name != "mac"
+
+- set_fact:
+ dockerInfo: "{{ dockerInfo_output.stdout|from_json }}"
+ when: whisk_version_name != "mac"
Review comment:
what about this condition? "mac" is gone so is this always done?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
