mdeuser commented on a change in pull request #2547: CLI Experimental api 
removal
URL: 
https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131187335
 
 

 ##########
 File path: tests/src/test/scala/whisk/core/cli/test/WskConfigTests.scala
 ##########
 @@ -149,9 +149,7 @@ class WskConfigTests
                 // Send request to https://<apihost>/api/v1/namespaces, wsk 
client passes client certificate to nginx, nginx will
                 // verify it by client ca's openwhisk-client-ca-cert.pem
                 val stdout = wsk.cli(Seq("property", "set", "-i", "--apihost", 
wskprops.apihost, "--auth", wskprops.authKey,
-                    "--cert", wskprops.cert, "--key", wskprops.key, 
"--namespace", namespace), env = env).stdout
 
 Review comment:
   jsut to clarify.  WskPropsV2 was used exclusively by API GW tests (needed 
the additional api gw token property plus a method i think).  it's really not 
api-experimental specific.  i thought this was a good time to consolidate back 
into a single WskProps.. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to