tysonnorris commented on a change in pull request #2414: SPI approach for
pluggable implementations
URL:
https://github.com/apache/incubator-openwhisk/pull/2414#discussion_r131217896
##########
File path: common/scala/src/main/scala/whisk/spi/SpiLoader.scala
##########
@@ -65,15 +72,20 @@ object SpiLoader {
}
}
-/**
- * Lookup the classname for the SPI impl based on a key in the provided Config
- */
+/** Lookup the classname for the SPI impl based on a key in the provided
Config */
object TypesafeConfigClassResolver extends SpiClassResolver {
- val config = ConfigFactory.load()
+ private val config = ConfigFactory.load()
+
override def getClassnameForKey(key: String): String =
config.getString(key)
override def getKeyForType[T](implicit man: Manifest[T]): String =
"whisk.spi." + man.runtimeClass.getSimpleName
}
+/**
+ * Object containing arbitrary objects acting as dependencies.
+ *
+ * This is solely a helper type to cross the border between possibly
heterogeneous Spi
Review comment:
Should "heterogeneous Spi interfaces" be "heterogeneous SpiFactoy
implementations"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
