underwoodb-sd-ibm commented on a change in pull request #2424: Allow optional
leading slash in CLI commands
URL:
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131748554
##########
File path: tests/src/test/scala/system/basic/WskBasicTests.scala
##########
@@ -75,6 +75,40 @@ class WskBasicTests
stderr should include(errormsg)
}
+ it should "accept a 3 part Fully Qualified Name without a leading '/'" in {
+ val auth: Seq[String] = Seq("--auth", wskprops.authKey)
+ val guestNamespace = wskprops.namespace
+ val packageName = "packageName3ptFQN"
+ val actionName = "actionName3ptFQN"
+ val triggerName = "triggerName3ptFQN"
+ val ruleName = "ruleName3ptFQN"
+ val fullQualifiedName =
s"${guestNamespace}/${packageName}/${actionName}"
+ val validArgs: Seq[Seq[String]] = Seq(
+ Seq("package", "create", packageName),
+ Seq("action", "create", fullQualifiedName, defaultAction.get),
+ Seq("action", "update", fullQualifiedName, defaultAction.get),
+ Seq("action", "invoke", fullQualifiedName),
+ Seq("trigger", "create", triggerName),
Review comment:
We put them in to test that 3 part FQN's could be used during rule creation.
A user could enter something like ```wsk rule create ruleName triggerName
namespace/packageName/actionName``` Is this unnecessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
