ningyougang commented on issue #2595: Move variable limits to 
ansible/group_vars/all
URL: 
https://github.com/apache/incubator-openwhisk/pull/2595#issuecomment-321198752
 
 
   @markusthoemmes , i have tested `local` and `distributed` env, it is ok. 
   But for `mac` and `docker-machine`, i don't have these envs in my local, so 
can't test it.
   
   But i am sure for `mac` and `docker-machine`, it will work well, why?
   You can see variable `defaultLimits`  is defined in 
`ansible/groups_vars/all` only,
   the `- name: (re)start controller` ansible task has a ENV 
`"DEFAULTLIMITS_ACTIONS_INVOKES_PERMINUTE": "{{ 
defaultLimits.actions.invokes.perMinute }}"`. so after modified for `limits`, 
`limits` and `defaultLimits` are symmetrical 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to